Ray Job work using Kuberay Python Client #858
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -136,6 +136,7 @@ def build_ray_cluster(cluster: "codeflare_sdk.ray.cluster.Cluster"): | |||
| "enableIngress": False, | |||
| "rayStartParams": { | |||
| "dashboard-host": "0.0.0.0", | |||
| "dashboard-port": "8265", | |||
There was a problem hiding this comment.
What is the reason for needing this addition?
There was a problem hiding this comment.
KubeRay should be exposing this automatically. I'd imagine this was part of trying to get the Job Agent stuff working.
|
|
||
| def __init__( | ||
| self, | ||
| job_name: str, |
There was a problem hiding this comment.
| job_name: str, | |
| name: str, |
| @@ -604,6 +609,298 @@ def _component_resources_down( | |||
| yamls = yaml.safe_load_all(self.resource_yaml) | |||
| _delete_resources(yamls, namespace, api_instance, cluster_name) | |||
|
|
|||
| @staticmethod | |||
There was a problem hiding this comment.
Could we take this out for now and commit it later with the full lifecyled cluster changes as part of https://issues.redhat.com/browse/RHOAIENG-26487
| @@ -604,6 +609,298 @@ def _component_resources_down( | |||
| yamls = yaml.safe_load_all(self.resource_yaml) | |||
| _delete_resources(yamls, namespace, api_instance, cluster_name) | |||
|
|
|||
| @staticmethod | |||
There was a problem hiding this comment.
We'll need to break this out if possible just because it's a beast to try and bring coverage up for. I've had to add a frightful amount of tests just to bump coverage into the 80s (still well below our threshold). Obviously this is a work-in-progress but the ticket may need to be rescoped to reflect this.
There was a problem hiding this comment.
agreed. if we can remove it for now as it will be delivered in https://issues.redhat.com/browse/RHOAIENG-26487
| @@ -136,6 +136,7 @@ def build_ray_cluster(cluster: "codeflare_sdk.ray.cluster.Cluster"): | |||
| "enableIngress": False, | |||
| "rayStartParams": { | |||
| "dashboard-host": "0.0.0.0", | |||
| "dashboard-port": "8265", | |||
There was a problem hiding this comment.
KubeRay should be exposing this automatically. I'd imagine this was part of trying to get the Job Agent stuff working.
Issue link
What changes have been made
Verification steps
Checks